fix(bench-243): by-region grid shows Singapore, not inherited us-east - #2230
Merged
Conversation
Flotapponnier
added a commit
that referenced
this pull request
Sep 1, 2026
fix: by-region grid driven by live spec (port from main #2230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegionGrid hardcoded us-east/eu-west/ap-southeast columns, so prod showed the us-east point inherited from the shared worker snapshot and had no Singapore column at all. Columns are now driven by the live spec: dimensions.region when declared, else the aggregate_filters.region pin, else the legacy three columns. Brings aggregate_filters schema+loader support to main (was dev-only #2227) and pins bench 243 to region=sgp.